Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add more resources #4

Merged
merged 16 commits into from
Jun 6, 2023
Merged

Feature/add more resources #4

merged 16 commits into from
Jun 6, 2023

Conversation

GuidoMaggio
Copy link
Member

@GuidoMaggio GuidoMaggio commented Nov 15, 2022 •
edited by riccardoporreca
Loading

PR created for review

At the current status:

  • GitHub action workflow failing
  • Some embedded sites do not display correctly, see discussion below

@GuidoMaggio GuidoMaggio added the enhancement New feature or request label Nov 15, 2022
@GuidoMaggio GuidoMaggio self-assigned this Nov 15, 2022
@GuidoMaggio
Copy link
Member Author

_site.zip

Uploaded local _site for @riccardoporreca

@GuidoMaggio
Copy link
Member Author

GHA to be updated

@GuidoMaggio
Copy link
Member Author

See comment in https://github.com/miraisolutions/meetings/issues/227

@riccardoporreca
Copy link
Member

riccardoporreca commented Dec 20, 2022 •
edited
Loading

Status update as of 2022-12-20

The following resources cannot be rendered in the gallery, since they are not meant to be embedded in an iframe

  • COVID-19 Switzerland BAG Dashboard by BAG [source]
  • COVID-19 Kanton Zurich Dashboard by Kanton ZH Statistiches Amt [source]
  • COVID-19 USA Dashboard by Prevent Epidemics [source]
  • COVID-19 Italy Dashboard by Istituto Superiore di Sanità [source]
  • COVID-19 United Kingdom Dashboard by Office for National Statistics [source]
    • Most graphics there can be individually embedded if we wanted to pick one
  • COVID-19 Denmark Dashboard by Danish Health Authority [source]
  • COVID-19 Austria Dashboard by Österreichische Agentur für Gesundheit und Ernährungssicherheit GmbH [source]

On a general note, we should double-check we are allowed to re-share the content for all resources in the gallery (not just those for which embedding is expilcitly prevented like in those above), to make sure we do not violate any terms of service (e.g. Terms of Service)

@GuidoMaggio
Copy link
Member Author

Check at legal disclaimers:

@GuidoMaggio
Copy link
Member Author

When building locally the latest version, upon clicking on a link a window opens also externally, causing sometimes problems

@GuidoMaggio
Copy link
Member Author

We can then finalise and publish it, making sure where the site cant be embedded the link works correctly

@GuidoMaggio
Copy link
Member Author

@riccardoporreca I managed to generate the site correctly, it works fine.
Those sites that cant be embedded do not appear but it is fine.

@riccardoporreca riccardoporreca mentioned this pull request Apr 11, 2023
Open
@riccardoporreca
Copy link
Member

Those sites that cant be embedded do not appear but it is fine.

Fine for now, although not ideal. I created as dedicated #6, but we can go with this first.

@GuidoMaggio GuidoMaggio merged commit 7476594 into master Jun 6, 2023
@riccardoporreca riccardoporreca deleted the feature/add-more-resources branch May 8, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardoporreca riccardoporreca riccardoporreca approved these changes

Assignees

@GuidoMaggio GuidoMaggio

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuidoMaggio @riccardoporreca