Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combined version of xlcCall + Attributes with deduplication #208

Closed
wants to merge 72 commits into from
Closed

combined version of xlcCall + Attributes with deduplication #208

wants to merge 72 commits into from

Conversation

spoltier
Copy link
Member

No description provided.

@spoltier
tinytex and necessary packages in devcontainer
d2febb7
@spoltier
Dockerfile - more TeX packages needed for vignettes
d8b18c0
@spoltier
R in vscode comes with lintr, disabling for now
3952ad8
@spoltier
run args for using podman in local devcontainers
72bf056
@spoltier
issue #37: add worksheetName with 'null' default
116982e
@spoltier
WIP troubleshooting java xlcall method
9abc9ab
@spoltier
poi 4.1.0 update dependency jars
50b112d
@spoltier
Updated XLConnect jar
2f40a57
@spoltier
POI 4.1.0 remove jar in wrong location
b9ec9e1
@spoltier
POI 4.1.0 - java changes recommended in review
5ec0173
@spoltier
POI 4.1.0: released xlconnect java
f24ecaf
@spoltier
#37: fix tests, use XLConnect java 1.0.0 + changes
55e6f54
@spoltier
#37 updated xlconnect java
c52ac8a
@spoltier
#37: clean up code, add test case
f0ea5c4
@spoltier
#37 add negative test case
bd23324
@spoltier
#37 documentation
36c7ae6
@spoltier
#37 fix doc of readNamedRegion
e50856d
@spoltier
gh #37: write in specific sheet's named region
b46d2c3
@spoltier
gh #37: create, check existence, and append to named region + tests
bc4c8f9
@spoltier
gh #37 clearNamedRegion of specified worksheet
338800d
@spoltier
gh #37: add clear Named region test with worksheet name
ed430f0
@spoltier
#37 create name: set worksheet if name provided
c6f3b4f
@spoltier
gh #37: sync jar, dev version
f0f213e
@spoltier
#37 add and clean up doc
abd0b45
@spoltier
gh#37 test: formula sheet vs scope sheet
93ffd3e
@spoltier
gh#37 fix scope v formula - sheet property in java
2fa5869
@spoltier
#37 fix clearNamedRegion (java), cleanup, clearer doc
b0e9835
@spoltier
gh#37: remove jcenter, seems down
476c7f3
@spoltier
gh #37: test cloning names
c8657e7
@spoltier
#37 fix cloning names (java)
9bf9146
@spoltier
addImage fix doc
b2608d1
@spoltier
review: dimension-abiding readNamedRegion
6dbcd55
@spoltier
Restore full clear named region check
cd6959f
@spoltier
Test write named to file with scope vector
0155ba9
@spoltier
Proposed fix, test change, fix read test
770a4ee
@spoltier
Fixed test
9e378f8
@spoltier
attributes (handling new java cls, setting attrs)
d50fd60
@spoltier
processing attributes, working for n scopes
0390b4d
@spoltier
jar - handle null scope in create
e374069
@spoltier
Adapted attribute handling with suggested approach
60131ac
@spoltier
correctly set names
28b9e01
@spoltier
clean up, ws scope attribute when null (jar)
1a5718e
@spoltier
WIP read named region attributes
58d7ec2
@spoltier
note after discussing with Riccardo
e8c55d6
@spoltier
attribute value is array of string
0b6c093
@spoltier
Attributes in dataframe from java
2e7d153
@spoltier
preserve attributes in extractRowNames
dbbb117
@spoltier
use xlconnect-java rebased - with overwriteFormulaCells
de8fe3d
@spoltier
Jar from rebased XLConnect-java (refactoring)
c65a0c1
@spoltier
comment at end of existing line to avoid lintr complaining
055dcc6
@spoltier
exclude all R code locations in lintr
34349e8
@spoltier
align xlcWithAttr... with changes to xlcCall
93fc50a
@spoltier
avoid overwriting names when setting attributes
a4bdccf
@spoltier
checkTrue instead of checkExists for bool with attributes
6af0efd
@spoltier
test write named region using (supported) scalar formula values only
12d4148
@spoltier
Doc: fix argument order in writeNamedRegionToFile
3bab24a
@spoltier
combined version of xlcCall + Attributes with deduplication
d603da9
@spoltier
.withAttributes: align doc
531ccd8
@spoltier spoltier closed this Jan 23, 2024
@spoltier spoltier deleted the feature/#37-merge-xlcCall branch March 6, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spoltier