Merge branch 'main' into misaka0508/main

misaka0508 · Sep 23, 2024 · 5a33247 · 5a33247
2 parents 8987f23 + b0138f7
commit 5a33247
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/SubRenamer/Services/RenameService.cs b/SubRenamer/Services/RenameService.cs
@@ -58,6 +58,12 @@ public void UpdateRenameTaskList(IReadOnlyList<MatchItem> matchList, Collection<
 
     public void ExecuteRename(IReadOnlyList<RenameTask> taskList)
     {
+        var backupEnabled = Config.Get().Backup;
+
+        // Record files that have been backed up,
+        // avoid duplicate backups when mapping is one-to-many (video-subtitle)
+        var filesHadBackup = new Dictionary<string, bool>();
+
         foreach (var task in taskList)
         {
             if (task.Status == "已修改") continue;
@@ -68,11 +74,14 @@ public void ExecuteRename(IReadOnlyList<RenameTask> taskList)
                 // Whether the origin and alter files are in the same folder
                 // If they are, rename in-place; otherwise, copy the file
                 var isSameFolder = Path.GetDirectoryName(task.Origin) == Path.GetDirectoryName(task.Alter);
-
+                
                 if (isSameFolder)
                 {
+                    // Backup (only rename in-place)
+                    if (backupEnabled && filesHadBackup.TryAdd(task.Origin, true))
+                        FileHelper.BackupFile(task.Origin);
+
                     // Rename in-place (like mv in linux)
-                    if (Config.Get().Backup) FileHelper.BackupFile(task.Origin);
                     FileHelper.RenameFile(task.Origin, task.Alter);
                 }
                 else