Interleave editor creation and file loading #3171
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I74eb4fa46fa35dbb709219b2dd87ffa5cd8a32c6 # Conflicts: # appinventor/appengine/src/com/google/appinventor/client/Ode.java # appinventor/appengine/src/com/google/appinventor/client/editor/FileEditor.java # appinventor/appengine/src/com/google/appinventor/client/editor/youngandroid/DesignToolbar.java # appinventor/appengine/src/com/google/appinventor/client/editor/youngandroid/YaBlocksEditor.java # appinventor/appengine/src/com/google/appinventor/client/editor/youngandroid/YaFormEditor.java # appinventor/appengine/src/com/google/appinventor/client/editor/youngandroid/YaProjectEditor.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to merge an optimization by @ewpatton as part of a refactor of editor handling into being screen based (a unit consisting of both form and blocks) from file based (a unit that is either form or blocks).
This code is still throwing errors, and I was unsuccessful in a more ambitious attempt to bring it more in line with the Promises update.
Throwing it up as a draft in hopes of getting some more eyes on it.