-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard Navigation #3193
Open
Venkata-Sai-Vishwanath-robo
wants to merge
39
commits into
mit-cml:master
Choose a base branch
from
Venkata-Sai-Vishwanath-robo:keyboardNavigation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Keyboard Navigation #3193
Changes from 15 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
31e818b
Focus component search box with /
Venkata-Sai-Vishwanath-robo fe22d80
shortcuts for refreshing companion screen and resetting connection
Venkata-Sai-Vishwanath-robo a6cd6c5
Rename component with Alt + R
Venkata-Sai-Vishwanath-robo 800c48c
Switch between design and blocks view
Venkata-Sai-Vishwanath-robo 9c4646c
Navigation for the project explorer
Venkata-Sai-Vishwanath-robo e9af08a
Navigation for dropdowns
Venkata-Sai-Vishwanath-robo ec12849
css
Venkata-Sai-Vishwanath-robo 64b4e99
Merge branch 'master' into keyboardNavigation
Venkata-Sai-Vishwanath-robo e8fc45a
shortcuts for blockly editor
Venkata-Sai-Vishwanath-robo b699190
Merge branch 'keyboardNavigation' of https://github.com/Venkata-Sai-V…
Venkata-Sai-Vishwanath-robo 87eb4c5
checkbox text for screen readers
Venkata-Sai-Vishwanath-robo 14501ed
Accessibility
Venkata-Sai-Vishwanath-robo d1f02f6
Tooltips and messages
Venkata-Sai-Vishwanath-robo b296f6c
better version of project explorer navigation
Venkata-Sai-Vishwanath-robo 4e2a979
neo
Venkata-Sai-Vishwanath-robo d53b293
adding components using keyboard only
Venkata-Sai-Vishwanath-robo 347b05b
focus SourceStructureExplorerItem on selection change.
Venkata-Sai-Vishwanath-robo 79f7391
Focus trap for new folder and new project dialog box
Venkata-Sai-Vishwanath-robo 6115d95
component adding
Venkata-Sai-Vishwanath-robo cd1c39e
property editors made keyboard accessible
Venkata-Sai-Vishwanath-robo 18484a3
better focus visibility for checkboxes and ColorChoicePropertyEditor
Venkata-Sai-Vishwanath-robo f4cb850
Dropdown button maintaing focus, check box visibility and UI settings…
Venkata-Sai-Vishwanath-robo 9a96f1a
Color choice property editor maintains focus after selection.
Venkata-Sai-Vishwanath-robo 25d4f32
tree highlight and focus-trap in move projects dialog
Venkata-Sai-Vishwanath-robo e7e3b0f
Focus search text box with / (better code)
Venkata-Sai-Vishwanath-robo e5d131f
single line imports
Venkata-Sai-Vishwanath-robo dc22e43
fix : Constructor visibility
Venkata-Sai-Vishwanath-robo 5963325
dialog boxes
Venkata-Sai-Vishwanath-robo b6f6330
updated isTextboxFocused method
Venkata-Sai-Vishwanath-robo 2a52e64
Update: Component adding
Venkata-Sai-Vishwanath-robo 4c98faf
Shortcuts Dialog box
Venkata-Sai-Vishwanath-robo 5f40827
fix: shortcuts dialog
Venkata-Sai-Vishwanath-robo ce12f23
Component Moving
Venkata-Sai-Vishwanath-robo 7ecfa20
tree highlighting upon click
Venkata-Sai-Vishwanath-robo ab4c3d4
Shortcuts dialog for neo
Venkata-Sai-Vishwanath-robo 1ea4775
Shortcuts to focus the Viewer and Properties, using V and P
Venkata-Sai-Vishwanath-robo 0244b78
fix: dropdown opens with no pre-selected item.
Venkata-Sai-Vishwanath-robo 7e7cad3
chore: remove unused code.
Venkata-Sai-Vishwanath-robo 080be5d
revert: remove unused code.
Venkata-Sai-Vishwanath-robo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to revisit this choice, since Alt on Windows typically maps to Cmd on macOS, and Cmd + R will refresh the page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does't Ctrl usually map to Cmd on MacOS in GUI aps? I usually expect Alt to map to Option.
I realize that we have a Ctrl button, and that works as Ctrl for a lot of command line stuff. There's no consistent official mapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback @ewpatton. I will look into these and fix them.
I will once go through the shortcuts in macOS and see for any more overlaps.
I still need to add code that adjusts the shortcut key messages based on whether the user is on Windows or macOS.
The community feedback is still pending, and I plan to complete it by the end of this week.