-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/facemesh ios #3215
Draft
Sufeenshaikh
wants to merge
11
commits into
mit-cml:ucr
Choose a base branch
from
Sufeenshaikh:feature/facemesh-ios
base: ucr
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/facemesh ios #3215
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
298f931
Implement FaceMesh functionality for iOS
Sufeenshaikh 70ec998
Implement FaceMesh functionality for iOS
Sufeenshaikh 5d0a527
added assets and faceemsh extension
Sufeenshaikh 15509ae
Added setMarkOrigin() ,setOriginX() and setOriginY() to ImageSprite a…
Sufeenshaikh 41523bb
Added missing functionalities
Sufeenshaikh 99519d9
Implement ShowMesh property and clean up code
Sufeenshaikh 17bb47e
imagepicker functionality
Sufeenshaikh 0f2cbbd
changes in runtime.scm and WebViewer
Sufeenshaikh b750646
Implement WKURLSchemeHandler and other changes
Sufeenshaikh 913eb7f
Implemented requested changes
Sufeenshaikh 85cd7b1
Make Facemesh work on iOS
ewpatton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,3 +70,4 @@ fastlane/test_output | |
|
||
iOSInjectionProject/ | ||
AICompanionApp.xcconfig | ||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ open class ImageSprite: Sprite { | |
fileprivate var _image = UIImage() | ||
fileprivate var _width = kLengthPreferred | ||
fileprivate var _height = kLengthPreferred | ||
|
||
public override init(_ parent: ComponentContainer) { | ||
super.init(parent) | ||
Width = kLengthPreferred | ||
|
@@ -39,13 +39,49 @@ open class ImageSprite: Sprite { | |
} | ||
} | ||
} | ||
|
||
@objc open var Image: UIImage { | ||
get { | ||
return _image | ||
} | ||
} | ||
|
||
@objc open func setMarkOrigin(_ originCoordinates: String) { | ||
// parse u and v with originCoordinates interpreted in "(u, v)" format | ||
|
||
let trimmed = originCoordinates.trimmingCharacters(in: CharacterSet(charactersIn: "()")) | ||
let components = trimmed.split(separator: ",") | ||
|
||
let doubleU = Double(components[0].trimmingCharacters(in: .whitespaces)) | ||
let doubleV = Double(components[1].trimmingCharacters(in: .whitespaces)) | ||
super.U = doubleU! | ||
super.V = doubleV! | ||
|
||
} | ||
|
||
//for setOriginX | ||
|
||
@objc open var setOriginX: Double { | ||
get { | ||
return super.U | ||
} | ||
set(u) { | ||
super.U = u | ||
} | ||
} | ||
|
||
//for setOriginY | ||
|
||
@objc open var setOriginY: Double { | ||
get { | ||
return super.V | ||
} | ||
set(v) { | ||
super.V = v | ||
} | ||
} | ||
|
||
|
||
@objc open var Rotates: Bool { | ||
get { | ||
return _rotates | ||
|
@@ -58,7 +94,7 @@ open class ImageSprite: Sprite { | |
} | ||
} | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clear out these minor changes and make the code consistent as possible |
||
override open var Heading: CGFloat { | ||
get { | ||
return super.Heading | ||
|
@@ -71,7 +107,7 @@ open class ImageSprite: Sprite { | |
} | ||
} | ||
} | ||
|
||
override open var Width: Int32 { | ||
get { | ||
return _width | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of these changes shouldn't have been added during github add, in a big project never do
git add .
. I know it's tedious but always dogit add <individual files you want to add>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. I'll be more careful with git add in the future.