ListView Android performance refactor

[SusanRatiLane]

General items:

• ant tests passes on my machine

• I branched from ucr

• My pull request has ucr as the base

Further, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):

• I have updated the corresponding version number in YaVersion.java
• I have updated the corresponding upgrader in YoungAndroidFormUpgrader.java (components only)
• I have updated the corresponding entries in versioning.js

^^ I have actually never done this, so we'll need to talk.

Description

This is a performance refactor submitted by @patryk84a in February 2024. He also included some methods for adding and removing items that the class should probably have. I included implementations for these in iOS.

He also included one aesthetic property for which I included a stub for iOS.

Fixes #2857

Original PR (now closed): #3099

Co-author: @patryk84a

[SusanRatiLane]

Hmm. I thought the tests were passing, but two ListView ones are not. Patryk's changes have broken an assumption the tests are making, but I'm trying to sort out what it is.

ETA: Tests now passing.

[patryk84a]

The HintSearchText property has been removed. Maybe instead for Android add a fixed hint text but from the Android resources "@android:string/search_go", then we should get the string in the language set in the phone, without the possibility of defining your own, which would be compatible with IOS

[SusanRatiLane]

The HintSearchText property has been removed. Maybe instead for Android add a fixed hint text but from the Android resources "@android:string/search_go", then we should get the string in the language set in the phone, without the possibility of defining your own, which would be compatible with IOS

Actually, that was removed because someone else wrote a PR that adds the property for both Android and iOS. I should probably have mentioned that in the PR description.

[ewpatton]

In addition to the file level and inline comments, the LISTVIEW_COMPONENT_VERSION value in YaVersion needs to be bumped to the change in the properties, and the appropriate code paths in YoungAndroidFormUpgrader.java and versioning.js need to be added.

[patryk84a]

I guess I can't make any changes here, right?

[SusanRatiLane]

I guess I can't make any changes here, right?

I should be able to give you access. I'll take a look.