Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
check_two_equal
may not able to check theNaN
case. We can improve it by usingstd::isnan
.When the following incorrect SIMD implementation runs on M1 environment, the test still passes. The cause of this issue is that
diff
becomesNaN
and the final check won't detectNaN
case.The fix is to add a check for
NaN
.Here is an incorrect implementation of
simd_programming
; however, it passes the current test.