Cmov using sbb when possible #1596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
reviewed
Apr 28, 2023
src/Rewriter/RulesProofs.v
Outdated
Comment on lines
574
to
580
|
|
||
| match goal with H5 : _ |- _ => apply unfold_is_bounded_by_bool in H5; cbn in H5 end. | ||
| replace c with 1 in * by lia. | ||
| rewrite Z.mod_opp_l_nz; rewrite ?Z.mod_small. | ||
| replace (M+1-1) with M by lia. | ||
| remove_casts. | ||
| all : try lia. |
There was a problem hiding this comment.
Is there any way this can be made more automated, and integrated with the above automation? Like M+1-1 should be folded into interp_good_t_step_arith if possible, etc
There was a problem hiding this comment.
I don't see anything useful to do here. I could wrap the thing in a match clause but I worry doing so might make maintenance harder, not easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to get decent code for saturated subtraction on clang with intrinsics