Only upload one copy of linux binaries to releases #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
force-pushed
the
standalone-package-only-static-release
branch
6 times, most recently
from
59cddef
to
bea8f57
Compare
JasonGross
force-pushed
the
standalone-package-only-static-release
branch
3 times, most recently
from
2cfd9d0
to
7794d61
Compare
JasonGross
commented
Nov 14, 2023
.github/workflows/coq-macos.yml
Outdated
| tag="$(git describe --tags HEAD)" | ||
| fname="Fiat-Cryptography_${tag}_macOS_${arch}.tar.gz" | ||
| echo "$fname" | ||
| mv dist-macos/standalone.tar.gz "dist/$fname" | ||
| find dist | ||
| tar -tvf dist/fiat-crypto-macos.tar.gz |
There was a problem hiding this comment.
Mac fails because I forgot to update this line, everything else passes
We upload the statically-linked Alpine edge binaries, as these are probably the most portable. Note that the statically-linked Alpine binaries are actually smaller than the Debian executables (~35 MB archive vs ~41 MB archive), though the Debian ones are pie (position-independent executables, supporting Address Space Layout Randomization).
JasonGross
force-pushed
the
standalone-package-only-static-release
branch
from
7794d61
to
36d10b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upload the statically-linked Alpine edge binaries, as these are
probably the most portable.
Note that the statically-linked Alpine binaries are actually smaller
than the Debian executables (~35 MB archive vs ~41 MB archive), though
the Debian ones are pie (position-independent executables, supporting
Address Space Layout Randomization).
Current names file names:
fiat-crypto-windows.zip
fiat-crypto-macos.tar.gz
fiat-crypto-linux-x86_64.tar.gz
Suggestions welcome cc @andres-erbsen