Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Remove dead code #1903

Merged
merged 2 commits into from
May 12, 2024
Merged

[CI] Remove dead code #1903

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7de8ae
[CI] Remove dead code
JasonGross May 10, 2024
94ed9b3
[CI] Simplify docker image saving a bit more (#1905)
JasonGross May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 3 additions & 21 deletions .github/workflows/coq-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,31 +130,13 @@ jobs:
with:
coq_version: ${{ matrix.env.DOCKER_COQ_VERSION }}
ocaml_version: ${{ matrix.env.DOCKER_OCAML_VERSION }}
export: CI ALLOW_DIFF COQCHKEXTRAFLAGS GITHUB_STEP_SUMMARY COQ_IMAGE
export: CI ALLOW_DIFF COQCHKEXTRAFLAGS GITHUB_STEP_SUMMARY COQ_IMAGE GITHUB_ENV
custom_script: |
printf "'%s'\n" "${COQ_IMAGE}"
printf "%s" "${COQ_IMAGE}" > .coqimage
- name: Set COQ_IMAGE
run: |
COQ_IMAGE="$(cat .coqimage)"
# N.B. This block can be removed once https://github.com/coq-community/docker-coq-action/pull/89 is merged
# we can just do `echo "COQ_IMAGE=$(cat .coqimage)" >> $GITHUB_ENV` then
if [ -z "${COQ_IMAGE}" ]; then
echo "::warning::.coqimage is empty, parsing docker images for coqorg/coq:.*${{ matrix.env.DOCKER_COQ_VERSION }}.*"
echo "::group::docker images"
docker images
echo "::endgroup::"
echo "::group::docker images --format '{{.Repository}}:{{.Tag}}'"
docker images --filter "reference=coqorg/coq*" --format "{{.Repository}}:{{.Tag}}"
echo "::endgroup::"
COQ_IMAGE="$(docker images --filter "reference=coqorg/coq*" --format "{{.Repository}}:{{.Tag}}" | grep -o 'coqorg/coq:.*${{ matrix.env.DOCKER_COQ_VERSION }}.*')"
fi
echo "COQ_IMAGE=${COQ_IMAGE}" >> $GITHUB_ENV
echo "COQ_IMAGE=${COQ_IMAGE}" | tee -a $GITHUB_ENV
- run: docker save "$COQ_IMAGE" -o image.tar
- name: Set coq_image_name Output to ${{ runner.os }}-docker-${{ hashFiles('image.tar') }}
id: set-output-step
run: |
echo "coq_image_name=${{ runner.os }}-docker-${{ hashFiles('image.tar') }}" >> $GITHUB_OUTPUT
run: echo "coq_image_name=${{ runner.os }}-docker-${{ hashFiles('image.tar') }}" >> $GITHUB_OUTPUT
- name: Cache Docker image
uses: actions/cache@v3
with:
Expand Down
Loading