Better computation of loose bounds #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
force-pushed
the
accurate-bounds
branch
from
c205391 to
ea15d52
Compare
|
@andres-erbsen @jadephilipoom Could you review the changes I made here to the definition of |
jadephilipoom
approved these changes
May 27, 2020
We now compute the loose bounds by recording the number of additions and/or balanced subtractions we want to be able to do in a row before we need to multiply and carry. Note that balanced subtraction always takes a bit more overhead than addition. This is a more conservative variant of mit-plv#799 that doesn't actually change the bounds, and makes the genuine change of mit-plv#799 easier to see, namely, reducing `headspace_add_count` from `2` to `1`.
JasonGross
force-pushed
the
accurate-bounds
branch
from
ea15d52 to
cfca4aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now compute the loose bounds by recording the number of additions
and/or balanced subtractions we want to be able to do in a row before we
need to multiply and carry. Note that balanced subtraction always takes
a bit more overhead than addition.
This is a more conservative variant of #799 that doesn't actually change
the bounds, and makes the genuine change of #799 easier to see, namely,
reducing
headspace_add_countfrom2to1.