Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update update-ngxblocker - added check_depends to check_version #584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danci1973
Copy link
Contributor

update-ngxblocker -v didn't work as check_version was called without 'check_depends' and didn't get all binaries / paths.

update-ngxblocker -v didn't work as check_version was called without 'check_depends' and didn't get all binaries / paths.
@itoffshore
Copy link
Collaborator

update-ngxblocker -v didn't work as check_version was called without 'check_depends' and didn't get all binaries / paths.

Well spotted - I think a better change is to move check_depends on line 348 in main() to be before where the command line options are read (& check_version can possibly be run). This is the natural place to expect any initialization to be done:

I have some notes on squashing commits / force overwriting a remote branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants