Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoctrineUserProvider fixed UserProvider contract usage #128

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

torniker
Copy link

In laravel 5.1 UserProviderInterface has been removed so I changed it to the correct one from Illuminate\Contracts\Auth\UserProvider.

@GrahamCampbell
Copy link

You'd need to drop support for laravel 4 and 5.0 first...

@torniker
Copy link
Author

I think for the repository would be best if it supports laravel 5.1 because it is announced as LTS version of laravel and I think a lot of users will use it. Of course it would be nice to have branches for laravel 4 and laravel 5.0

@GrahamCampbell
Copy link

Unfortunately, the package maintainer has already used the wrong version constraint. This package is marked as compatible with all 5.x releases, and it clearly isn't. Changing the version constraint at a later point simply isn't good enough because composer will just go and install the old version since it's marked as compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants