Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ON HOLD] hide tab when no results #1224

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ChristopherChudzicki
Copy link
Contributor

@ChristopherChudzicki ChristopherChudzicki commented Jul 3, 2024

On hold pending decision whether we actually want to do this.

What are the relevant tickets?

Description (What does it do?)

Hides search tabs when there are no results.

Screenshots (if appropriate):

Video:

tabs_video.mov

If tab has 0 results but is active, show it:

Screenshot 2024-07-08 at 11 48 36 AM

If tab has 0 results but is not active, hide it:

Screenshot 2024-07-08 at 11 48 45 AM

How can this be tested?

  1. Check that tab is hidden if there are not results:
    • Search for something like "cats" that will have no programs. The "Programs" tab should disappear.
  2. Check that if the tab is active AND there are no results, it is still visible.
    • clear your search
    • select the "Programs" tab
    • repeat your search for "cats" (or whatever) from (1).

@ChristopherChudzicki ChristopherChudzicki added the Needs Review An open Pull Request that is ready for review label Jul 8, 2024
@ChristopherChudzicki ChristopherChudzicki marked this pull request as ready for review July 8, 2024 15:58
@shanbady shanbady self-assigned this Jul 8, 2024
@ChristopherChudzicki ChristopherChudzicki removed the Needs Review An open Pull Request that is ready for review label Jul 8, 2024
@ChristopherChudzicki ChristopherChudzicki changed the title hide tab when no results [ON HOLD] hide tab when no results Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants