-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new cart designs #2505
Merged
Merged
Adding new cart designs #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagav
force-pushed
the
ag/cart_design
branch
from
January 10, 2025 16:00
e25fe13
to
b8f8cb2
Compare
annagav
force-pushed
the
ag/cart_design
branch
2 times, most recently
from
January 13, 2025 13:27
ba3b188
to
f178025
Compare
annagav
force-pushed
the
ag/cart_design
branch
from
January 13, 2025 14:53
1f318cb
to
f34712b
Compare
for more information, see https://pre-commit.ci
cp-at-mit
approved these changes
Jan 13, 2025
Let me know how/when I can see this on RC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Related to https://github.com/mitodl/hq/issues/5662
Description (What does it do?)
Adding new cart designs
There are some changes that are under the feature flag:
And some that are not:
Note: This PR does not include the addition of the new confirmation dialog. This will be added in a separate PR.
Screenshots (if appropriate):
The flag turned off:
The flag turned on:
How can this be tested?
Switch on and off the feature flag
new-cart-design