[Bug Fix] unable to login Docker #3040
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Able to log in on docker
allows server to be built and actually usable on docker
add the build arg
clear up non needed tasks
BurnyMack
approved these changes
Sep 15, 2024
|
Can someone review this issue please? |
|
This works for me. The docker-compose.yml file can be something like this. |
rfulwell
reviewed
Nov 26, 2024
| # Set up config file and disable atomic by default | ||
| RUN python3 -c "import app; import app.utility.config_generator; app.utility.config_generator.ensure_local_config();"; \ | ||
| sed -i '/\- atomic/d' conf/local.yml; | ||
| # Set up config file and dont disable atomic by default |
There was a problem hiding this comment.
nitpick: it should be "don't"
alternatively skip the negative part of the comment altogether:
Suggested change
| # Set up config file and dont disable atomic by default | |
| # Set up config file |
rfulwell
reviewed
Nov 26, 2024
| @@ -27,9 +27,9 @@ ENV PATH="$VIRTUAL_ENV/bin:$PATH" | |||
| # Install pip requirements | |||
| RUN pip3 install --no-cache-dir -r requirements.txt | |||
|
|
|||
| # Set up config file and disable atomic by default | |||
| RUN python3 -c "import app; import app.utility.config_generator; app.utility.config_generator.ensure_local_config();"; \ | |||
| sed -i '/\- atomic/d' conf/local.yml; | |||
There was a problem hiding this comment.
Do we know why atomic was being disabled previously?
rfulwell
reviewed
Nov 26, 2024
| apt-get autoremove -y && \ | ||
| apt-get clean && \ | ||
| rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* | ||
| apt-get install -y nodejs npm |
There was a problem hiding this comment.
it looks like this change will not build the magma plugin - is that right?
rfulwell
reviewed
Nov 26, 2024
| @@ -150,6 +150,7 @@ async def start_vue_dev_server(): | |||
| def configure_magma_env_file(): | |||
| logging.info("Setting VueJS environment file.") | |||
| url = BaseWorld.get_config("app.frontend.api_base_url") | |||
| logging.info(f"Successfuly set {url} as base url.") | |||
There was a problem hiding this comment.
nitpick:
Suggested change
| logging.info(f"Successfuly set {url} as base url.") | |
| logging.info(f"Successfully set {url} as base url.") |
rfulwell
reviewed
Nov 26, 2024
| @@ -265,8 +266,7 @@ def list_str(values): | |||
| logging.info("Building VueJS front-end.") | |||
| subprocess.run(["npm", "run", "build"], cwd=MAGMA_PATH, check=True) | |||
| logging.info("VueJS front-end build complete.") | |||
| app_svc.application.on_response_prepare.append(enable_cors) | |||
|
|
|||
There was a problem hiding this comment.
is this intentionally removing the blank line and nothing else?
|
im not going to lie i completely forgot everything, i did this pull request when i was doing my university project. Hopefully everything goes well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] Docker not being able to log in
Docker front end being built before running and writing the env file, which causes users not being able to login. ./Magna/.env needs to exist before building,which doesnt happen for docker
Bug fix
Removed Previous Dockerfile
downloaded new one and built it (docker build . --build-arg WIN_BUILD=true -t caldera:latest
)
then to run the docker image i ran:
docker run -p 8888:8888 caldera:latest --build
then i accessed the web page according my base url i set in the local.yml file
logged in successfully according to my local.yml credentials :)