feat: implemented submit chunking for RFD #0010 #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for chunking Query submissions - Added test for submission chunking Signed-off-by: Patrick Casey <[email protected]>
patrickjcasey
force-pushed
the
patrickjcasey/rfd10-proto-changes
branch
from
e6d0795 to
a11f303
Compare
j-lanson
requested changes
Dec 23, 2024
Comment on lines
+179
to
+181
| QueryState::SubmitInProgress | QueryState::SubmitComplete => { | ||
| return Err(Error::ReceivedSubmitWhenExpectingReplyChunk) | ||
| } |
There was a problem hiding this comment.
I believe the QuerySynthesizer needs to be modified as well to support de-chunking chunked Submit queries.
Comment on lines
+259
to
+262
| // ensure last one is ...Complete | ||
| assert_eq!(res.last().unwrap().state(), final_state); | ||
| assert_eq!(res.len(), 4); | ||
| } |
There was a problem hiding this comment.
To ensure the above QuerySynthesizer is implemented correctly, perhaps there should be an additional stage to this test that tries to reassemble the original message from the fragments.
|
On the subject of versioning, I would do the following:
We can add RFD10 to On the next release, we will release new versions of the rust SDK and all plugins. |
|
This is not quite done yet, still working through a couple of things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just want to ensure that adding an enum variant to
QueryStateis not considered a breaking change. Also since this changeshipcheck-common, does its version need be incremented or do we just handle that when it comes time to cut a release