fix syntax issues #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmetzger
commented
Aug 29, 2024
* replaced usage of "permissions" with "mode" when appropriate Signed-off-by: kemley76 <[email protected]> * simplified SV-257926 Signed-off-by: kemley76 <[email protected]> * standardized use of "exempt" vs "exemption" in various inputs * fix missed variable rename Signed-off-by: kemley76 <[email protected]> * remove a debugging test Signed-off-by: kemley76 <[email protected]> * standardize format to be exempt_<thing that is exempt> Signed-off-by: Kaden Emley <[email protected]> --------- Signed-off-by: kemley76 <[email protected]> Signed-off-by: Kaden Emley <[email protected]> Co-authored-by: suhanimalhotra <[email protected]>
jrmetzger
commented
Aug 30, 2024
controls/SV-257787.rb
Outdated
There was a problem hiding this comment.
look into file once first
jrmetzger
commented
Aug 30, 2024
There was a problem hiding this comment.
leave variable not hard coded
jrmetzger
commented
Aug 30, 2024
controls/SV-257937.rb
Outdated
There was a problem hiding this comment.
test logic double test this
jrmetzger
commented
Aug 30, 2024
controls/SV-257967.rb
Outdated
There was a problem hiding this comment.
plural works in rhel9, verified
jrmetzger
commented
Aug 30, 2024
controls/SV-257991.rb
Outdated
There was a problem hiding this comment.
want the server config
jrmetzger
commented
Aug 30, 2024
controls/SV-257989.rb
Outdated
There was a problem hiding this comment.
we want opensshserver
jrmetzger
commented
Aug 30, 2024
controls/SV-257990.rb
Outdated
…nd client Signed-off-by: Will <[email protected]>
Signed-off-by: Will <[email protected]>
jrmetzger
commented
Aug 30, 2024
jrmetzger
commented
Aug 30, 2024
jrmetzger
commented
Aug 30, 2024
There was a problem hiding this comment.
Check for approved as well. enabled =
added 2 commits
September 3, 2024 10:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.