Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds vectorization to the
BSDFContext
datastructure passed to the BSDF routines (e.g.eval()
,sample()
,pdf()
). This allows the callee to specify the BSDF components and event types to be sampled/evaluated on a per-lane basis. This is very useful for implementing non-conventional integrators for the vectorized variants of Mitsuba (e.g. light path expression, ...).This PR adapts the code of all BSDFs to use masking logic to handle the non-scalar conditions based on the BSDF context object.
Testing
On top of the current test suite which already tests the activation/de-activation of the BSDF components using the BSDFConext, I added a simple test in
test_dielectric.py
to test it in a vectorized way.