Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The shading frame in the
normalmap
BSDF was not computed correctly.The shading frame-local normal was used in conjunction with the world-space
dp_du
to construct the perturbed shading frame.The shading frame in turn was interpreted as the "shading frame in world space", as well as the relative transformation between the original shading frame and the perturbed one...
Testing
resources/data/tests/scenes/git/test_normalmap_roughconductor_path.xml
has been added in my fork of the mitsuba-data repository to verify the changes.(But this probably does not really count here, does it?)
The improved correctness relative to the previous implementation can be seen if the normal-mapped rendering is compared to a not normal-mapped rendering.
I have added
src/bsdfs/tests/test_normalmap.py
, that verifies that sampling from a normal-mapped BSDF is the same as sampling from the nested BSDF with an appropriately rotated surface interaction.Checklist
cuda_*
andllvm_*
variants. If you can't test this, please leave below