Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(List): fix error when using defaultValues #1082

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix(List): fix error when using defaultValues #1082

merged 2 commits into from
Dec 18, 2024

Conversation

mfal
Copy link
Member

@mfal mfal commented Dec 16, 2024

No description provided.

@mfal mfal linked an issue Dec 16, 2024 that may be closed by this pull request
Exception when using List with Filter and defaultSelected #1075
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 31.15% 4672 / 14998
🔵 Statements 31.15% 4672 / 14998
🔵 Functions 59.49% 445 / 748
🔵 Branches 76.24% 748 / 981
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/src/components/List/model/filter/Filter.ts 68.93% 75% 80.64% 68.93% 88, 100-101, 110, 112-114, 120, 146-148, 155-159, 176, 185-186, 189-203, 225-240, 243-245, 248-266
packages/components/src/components/List/model/filter/FilterValue.ts 78.94% 66.66% 75% 78.94% 15-16, 26-27, 44-45, 48-49
packages/components/src/components/List/model/filter/types.ts 100% 100% 100% 100%
packages/components/src/lib/array/toArray.ts 100% 50% 100% 100%
Generated in workflow #1899 for commit a1d74cc by the Vitest Coverage Report Action

@mfal mfal force-pushed the 1075-exception-when-using-list-with-filter-and-defaultselected branch from 1f1ab52 to bf809a6 Compare December 16, 2024 13:20
@mfal mfal temporarily deployed to github-pages-preview December 16, 2024 13:20 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview-storybook December 16, 2024 13:20 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 merged commit 68ec508 into main Dec 18, 2024
4 checks passed
@Lisa18289 Lisa18289 deleted the 1075-exception-when-using-list-with-filter-and-defaultselected branch December 18, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lisa18289 Lisa18289 Lisa18289 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when using List with Filter and defaultSelected
2 participants
@mfal @Lisa18289