Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file card component #928

Merged
merged 13 commits into from
Nov 4, 2024
Merged

Add file card component #928

merged 13 commits into from
Nov 4, 2024

Conversation

Lisa18289
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2024 •
edited
Loading

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 27.36% 3870 / 14140
🔵 Statements 27.36% 3870 / 14140
🔵 Functions 30.99% 208 / 671
🔵 Branches 54.35% 443 / 815
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/vite.build.config.base.ts 0% 0% 0% 0% 1-141
packages/components/src/components/ColumnLayout/ColumnLayout.tsx 0% 0% 0% 0% 1-64
packages/components/src/components/FileCard/FileCard.tsx 0% 0% 0% 0% 1-73
packages/components/src/components/FileCard/index.ts 0% 0% 0% 0% 1-4
packages/components/src/components/FileCard/components/FileSizeText/FileSizeText.tsx 0% 0% 0% 0% 1-25
packages/components/src/components/FileCard/components/FileSizeText/index.ts 0% 0% 0% 0% 1
packages/components/src/components/FileCard/stories/Default.stories.tsx 0% 0% 0% 0% 1-27
packages/components/src/components/FileCard/stories/EdgeCases.stories.tsx 0% 0% 0% 0% 1-17
packages/components/src/components/FileCardList/FileCardList.tsx 0% 0% 0% 0% 1-24
packages/components/src/components/FileCardList/index.ts 0% 0% 0% 0% 1-4
packages/components/src/components/FileCardList/stories/Default.stories.tsx 0% 0% 0% 0% 1-22
packages/components/src/components/Icon/components/icons/IconFile.tsx 60% 100% 0% 60% 8-12
packages/components/src/components/Icon/components/icons/IconImage.tsx 60% 100% 0% 60% 8-12
packages/components/src/components/Icon/components/icons/index.ts 100% 100% 100% 100%
packages/components/src/components/propTypes/index.ts 100% 100% 100% 100%
Generated in workflow #1684 for commit 57fd224 by the Vitest Coverage Report Action

@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview October 31, 2024 06:56 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook October 31, 2024 06:56 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview October 31, 2024 07:04 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook October 31, 2024 07:04 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview October 31, 2024 07:15 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook October 31, 2024 07:15 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook October 31, 2024 07:20 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview October 31, 2024 07:20 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook October 31, 2024 07:32 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview October 31, 2024 07:32 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 self-assigned this Oct 31, 2024
@mfal mfal self-requested a review November 4, 2024 11:53
mfal
mfal requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@mfal mfal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestion

@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook November 4, 2024 11:59 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview November 4, 2024 11:59 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview-storybook November 4, 2024 12:05 — with GitHub Actions Inactive
@Lisa18289 Lisa18289 temporarily deployed to github-pages-preview November 4, 2024 12:05 — with GitHub Actions Inactive
@Lisa18289
Merge remote-tracking branch 'refs/remotes/origin/main' into add-file…
6055075 
…-card-component

# Conflicts:
#	packages/design-tokens/src/status/file-card.yml
@mfal mfal merged commit 7cd379a into main Nov 4, 2024
4 checks passed
@mfal mfal deleted the add-file-card-component branch November 4, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfal mfal mfal approved these changes

Assignees

@Lisa18289 Lisa18289

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lisa18289 @mfal