Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Button): support avatar in button #930

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

Lisa18289
Copy link
Member

No description provided.

@Lisa18289 Lisa18289 self-assigned this Oct 31, 2024
@Lisa18289 Lisa18289 marked this pull request as draft October 31, 2024 12:09
Copy link
Contributor

github-actions bot commented Oct 31, 2024

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 27.57% 3860 / 13998
🔵 Statements 27.57% 3860 / 13998
🔵 Functions 31.56% 208 / 659
🔵 Branches 55.03% 443 / 805
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/components/src/components/Button/stories/Default.stories.tsx 0% 0% 0% 0% 1-12, 14-45, 47, 50, 52-56, 58-62, 64, 66-70, 72-73, 75-80, 82, 84-89, 91-94, 96-106, 108
packages/components/src/components/MenuItem/MenuItemContent.tsx 19.29% 100% 0% 19.29% 24-29, 31-41, 43-47, 49-57, 59, 62-63, 65-75, 77
Generated in workflow #1671 for commit c4ed7a8 by the Vitest Coverage Report Action

@Lisa18289 Lisa18289 marked this pull request as ready for review October 31, 2024 12:25
@Lisa18289 Lisa18289 changed the title feat(Button):support avatar feat(Button): support avatar in button Nov 5, 2024
@elmartinezc elmartinezc merged commit 233b656 into main Nov 5, 2024
4 checks passed
@elmartinezc elmartinezc deleted the support-avatar-in-button-and-menu-item branch November 5, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants