fix: remove scaleSignal in waveform analyzer #13416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this hasn't been merged immediately after #13106, doesn't this require another version bump? |
|
It hasn't been that long, so could we assume it is still fine to do it now? If we wait more, agreed it will need another bump. |
|
A version bump, is cheap now that we have already a bump. Regular user needs to reanalyze after update anyway. So let's bump again and avoid inconsistency for alpha users. |
acolombier
force-pushed
the
fix/remove-signal-scale
branch
from
f6052c4
to
c998638
Compare
acolombier
force-pushed
the
fix/remove-signal-scale
branch
from
c998638
to
eb1b605
Compare
|
Updated - are we happy with my approach to make a minor bump? |
ywwg
approved these changes
Jul 20, 2024
daschuer
requested changes
Jul 21, 2024
|
@acolombier Unfortunately there is a merge conflict now |
|
Updated @JoergAtGithub - hopefully this can go in now! |
|
there is a weird compilation error (maybe whitespace related?). Can you look into that? |
ywwg
approved these changes
Sep 17, 2024
|
@daschuer merge? |
|
there is still an MSVC error. Can you look into that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the signal scaling applied on bass and global signal.
@m0dB @ywwg @JoergAtGithub your review and test would be very appreciated! :)
Depends on #13106 , which contains the Waveform version bump.