document ScriptConnection readonly properties & slight cleanup
#13630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use initializer lists * remove unneeded QString member, saving 24 bytes in this frequently instanced class * pass by Value+Move instead of unconditional copy in ctor
and construct connectControl warning message more efficiently
Swiftb0y
force-pushed
the
feat/document-script-connection-readonly-properties
branch
from
1a06075
to
875a6a3
Compare
|
Tested the extended TypeScript declaration with Visual Studio Code. It works as intended! |
JoergAtGithub
approved these changes
Sep 6, 2024
|
LGTM! Thanky you! |
|
Thanks. |
Swiftb0y
deleted the
feat/document-script-connection-readonly-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.