Merge pull request wolfSSL#7062 from lealem47/leaks

Cleanup leaks in api.c and benchmark.c
miyazakh · Dec 13, 2023 · a66137d · a66137d
2 parents 8acee81 + 5fd0470
commit a66137d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/tests/api.c b/tests/api.c
@@ -68772,6 +68772,12 @@ static int test_dtls13_early_data(void)
 
     ExpectTrue(wolfSSL_session_reused(ssl_c));
     ExpectTrue(wolfSSL_session_reused(ssl_s));
+
+    wolfSSL_SESSION_free(sess);
+    wolfSSL_free(ssl_c);
+    wolfSSL_free(ssl_s);
+    wolfSSL_CTX_free(ctx_c);
+    wolfSSL_CTX_free(ctx_s);
 #endif
     return EXPECT_RESULT();
 }

diff --git a/wolfcrypt/benchmark/benchmark.c b/wolfcrypt/benchmark/benchmark.c
@@ -2941,14 +2941,18 @@ static void* benchmarks_do(void* args)
         bench_plain = (byte*)XMALLOC((size_t)bench_buf_size + 16*2,
                                  HEAP_HINT, DYNAMIC_TYPE_WOLF_BIGINT);
 
-        if (bench_plain == NULL)
+        if (bench_plain == NULL) {
+            XFCLOSE(file);
             goto exit;
+        }
 
         if ((size_t)XFREAD(bench_plain, 1, rawSz, file)
                 != (size_t)rawSz) {
             XFCLOSE(file);
             goto exit;
         }
+
+        XFCLOSE(file);
     }
     else {
         XMEMSET(bench_plain, 0, (size_t)bench_buf_size);
@@ -2984,14 +2988,18 @@ static void* benchmarks_do(void* args)
         bench_cipher = (byte*)XMALLOC((size_t)bench_buf_size + 16*2,
                                  HEAP_HINT, DYNAMIC_TYPE_WOLF_BIGINT);
 
-        if (bench_cipher == NULL)
+        if (bench_cipher == NULL) {
+            XFCLOSE(file);
             goto exit;
+        }
 
         if ((size_t)XFREAD(bench_cipher, 1, rawSz, file)
                 != (size_t)rawSz) {
             XFCLOSE(file);
             goto exit;
         }
+
+        XFCLOSE(file);
     }
     else {
         XMEMSET(bench_cipher, 0, (size_t)bench_buf_size);