Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional flowmodel #319

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Conditional flowmodel #319

merged 9 commits into from
Apr 8, 2024

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Jul 26, 2023

Support training conditional flows in FlowModel.

This isn't useful now, but will enable a conditional version of FlowProposal that may be useful in some scenarios

@mj-will mj-will added the enhancement New feature or request label Jul 26, 2023
@mj-will mj-will added this to the v0.10.0 milestone Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.54%. Comparing base (fedcdf7) to head (c8e3361).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   93.52%   93.54%   +0.01%     
==========================================
  Files          67       67              
  Lines        6536     6565      +29     
==========================================
+ Hits         6113     6141      +28     
- Misses        423      424       +1     
Flag Coverage Δ
unittests 93.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mj-will mj-will modified the milestones: v0.10.0, Future Oct 31, 2023
@mj-will mj-will force-pushed the conditional_flowmodel branch from c55df73 to 5c9e6c0 Compare December 11, 2023 17:26
@mj-will
Copy link
Owner Author

mj-will commented Dec 11, 2023

This PR requires that #358 be merged first

@mj-will mj-will force-pushed the conditional_flowmodel branch from 5c9e6c0 to 82459a1 Compare December 13, 2023 14:31
@mj-will mj-will force-pushed the conditional_flowmodel branch from 82459a1 to 139c8b4 Compare April 5, 2024 11:08
@mj-will mj-will modified the milestones: Future, v0.12.0 Apr 5, 2024
@mj-will mj-will force-pushed the conditional_flowmodel branch from 785b6f2 to c8e3361 Compare April 8, 2024 08:50
@mj-will mj-will merged commit 50dd7a9 into main Apr 8, 2024
36 checks passed
@mj-will mj-will deleted the conditional_flowmodel branch April 8, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant