-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework truncation based on log q #338
Conversation
a84aa2c
to
17cf217
Compare
117503d
to
ebff61d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 93.26% 93.29% +0.02%
==========================================
Files 67 67
Lines 6300 6322 +22
==========================================
+ Hits 5876 5898 +22
Misses 424 424
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm deferring documenting this to a later PR since this would require a lot of additional documentation and the method is still not recommended. |
Rework how the truncation based of the log-proposal probability (log q) to use the minium value of the training data.
Motivation
This could be an alternative to truncating the latent distribution. It should be less prone to over-constraining but may result in inefficient rejection sampling.
Changes
FlowModel
andBaseFlow
FlowProposal.radius
FlowProposal.backwards_pass
worst_q
tomin_log_q
inFlowProposal.rejection_sample
Breaking changes
These changes are all to options that were not used by default and we generally recommended avoiding in the past, so I don't think they should impact users.
truncate
keyword argument fromFlowProposal
worst_q
keyword argument tomin_log_q
inFlowProposal.rejection_sample
To-Do
Document the method