Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support one-to-many reparameterisations #418

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Aug 19, 2024

This PR adds support for one-to-many reparameterisations, e.g. for the reparameterisation proposed in mj-will/nessai-gw#1.

The main change is to skip the steps that ensure the reparameterisation are invertible if one_to_one is False.

@mj-will mj-will added the enhancement New feature or request label Aug 19, 2024
@mj-will mj-will added this to the v0.14.0 milestone Aug 19, 2024
@johnveitch johnveitch self-assigned this Aug 20, 2024
Copy link
Collaborator

@johnveitch johnveitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a clarification on the warning message

nessai/proposal/flowproposal.py Show resolved Hide resolved
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (7836002) to head (fd057d3).
Report is 112 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #418   +/-   ##
=======================================
  Coverage   93.59%   93.60%           
=======================================
  Files          69       69           
  Lines        6748     6755    +7     
=======================================
+ Hits         6316     6323    +7     
  Misses        432      432           
Flag Coverage Δ
unittests 93.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnveitch johnveitch merged commit 90526f3 into main Aug 20, 2024
30 checks passed
@mj-will mj-will deleted the support-one-to-many-reparams branch August 20, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants