-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor flowproposal into a submodule #419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj-will
added
the
refactor
Code changes that neither fixes a bug nor adds a feature
label
Aug 20, 2024
mj-will
force-pushed
the
refactor-flowproposal
branch
from
August 20, 2024 14:03
ef45202
to
efc327e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 93.60% 93.69% +0.09%
==========================================
Files 69 71 +2
Lines 6755 6807 +52
==========================================
+ Hits 6323 6378 +55
+ Misses 432 429 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mj-will
force-pushed
the
refactor-flowproposal
branch
from
August 20, 2024 14:10
efc327e
to
fd9ff51
Compare
This should simplify implementing the MCMC version of FlowProposal
mj-will
force-pushed
the
refactor-flowproposal
branch
from
August 28, 2024 10:30
cedccdb
to
4695692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on a version of
FlowProposal
that uses MCMC I realised it would be a lot easier if it could inherit from a base class that had also the training/reparameterisations but didn't include e.g. the options related to the latent contour. This PR refactorsnessai.proposal.flowproposal
into a submodule to hopefully make things simpler going forward.I've tried to keep the commits as simple as possible, so looking at fd9ff51 might be the easiest way to see that things haven't changed significantly (the same tests with minimal changes still pass)
Other changes
rejection_sampling
methodconfigure_poolsize
and changeconfigure_population
FlowProposal.set_rescaling
N
ton_samples
inverse
methodFlowModel
To-Do