Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: change setuptools-scm version scheme #420

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

mj-will
Copy link
Owner

@mj-will mj-will commented Aug 23, 2024

The current configuration for setuptools_scm doesn't return a sensible version number. My understanding is that this is a result of having a release branch that has the v0.13.2 and v0.13.1 releases on it rather than them being in master. The current version gives:

nessai-0.13.1.dev62+gb142cc4.d20240823

After this change, the version on main would be

nessai-0.14.0.dev62+gb142cc4

and the release-0.13.x branch it returns

nessai-0.13.3.dev0+g06af460

@mj-will mj-will added this to the v0.14.0 milestone Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (90526f3) to head (b142cc4).
Report is 109 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files          69       69           
  Lines        6755     6755           
=======================================
  Hits         6323     6323           
  Misses        432      432           
Flag Coverage Δ
unittests 93.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@johnveitch johnveitch assigned johnveitch and unassigned johnveitch Aug 23, 2024
@johnveitch johnveitch self-requested a review August 23, 2024 11:48
Copy link
Collaborator

@johnveitch johnveitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mj-will mj-will merged commit 3efb413 into main Aug 23, 2024
30 checks passed
@mj-will mj-will deleted the setuptools-scm-version-scheme branch September 2, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants