Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Class #17

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Changed Class #17

wants to merge 1 commit into from

Conversation

mac2net
Copy link

@mac2net mac2net commented Sep 11, 2017

Line 214 changed:
from: class="delete"
to: class="jrf_delete"

Line 214 changed: 
from: class="delete"
to:  class="jrf_delete"
@mac2net mac2net closed this Sep 11, 2017
@jrfnl
Copy link
Collaborator

jrfnl commented Sep 11, 2017

I cannot merge a closed PR (quite apart from it not being an acceptable class name). Try again ?

@mac2net
Copy link
Author

mac2net commented Sep 12, 2017

LOL, I solved the problem but I don't know how to work collaboratively with GitHub.
And I have a sense of humour.
https://www.youtube.com/watch?v=iLw9OBV7HYA
Please give me the class name you want.

@mac2net mac2net reopened this Sep 12, 2017
@jrfnl
Copy link
Collaborator

jrfnl commented Sep 13, 2017

LOL, I solved the problem but I don't know how to work collaboratively with GitHub.

That's luckily nowhere near as hard and a great skill to gain ;-)
As we both know what this is about, let's get this change in. For the future a little more descriptive PR title and commit message is advisable. Those texts become part of the change history of the plugin, so having them be descriptive and explaining in them what the problem is that's being solved is helpful for other people when changing things in the future.

And I have a sense of humour.

@mac2net Glad to hear it.

Please give me the class name you want.

I'd suggest for the class name to be the same as the id of the link in this case.
I also believe that a change in the CSS file will be needed: https://github.com/mjangda/plugin-notes/blob/develop/plugin-notes.css#L29

By the looks of it the js should be ok due to old-school onclick actions being used. Would love to see that changed, but that's for another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants