Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to work with MacOS #821

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

joshdentremont
Copy link
Contributor

Link to Github issue or other discussion

#814

What does this PR do?

Add's Noah's suggestion of using variables to chown the workbench directory

What changes were made?

updated dockerfile to use $USER_ID and $GROUP_ID variables

How to test / verify this PR?

Without this PR, building fails on MacOS. Testing should include building on Mac and Linux

Interested Parties

@noahwsmith @DonRichards @mjordan


Checklist

  • Before opening this PR, have you opened an issue explaining what you want to to do?
  • Have you included some configuration and/or CSV files useful for testing this PR?
  • Have you written unit or integration tests if applicable?
  • Does the code added in this PR require a version of Python that is higher than the current minimum version?
  • If the changes in this PR require an additional Python library, have you included it in setup.py?
  • If the changes in this PR add a new configuration option, have you provided a default for when the option is not present in the .yml file?

@noahwsmith
Copy link
Contributor

Oh- that looks like a much better solution!

@DonRichards
Copy link
Contributor

I agree this looks like a good fix.

@mjordan mjordan merged commit 7f7aafa into mjordan:main Sep 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants