change default histogram binning to Scott, closes #214

mjskay · Feb 24, 2024 · 8e801e9 · 8e801e9
1 parent c39e8ab
commit 8e801e9
Show file tree

Hide file tree

Showing 19 changed files with 29 additions and 27 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -38,6 +38,8 @@ Bug fixes:
 
 Minor changes:
 
+* The default histogram bin selection algorithm is now `"Scott"` instead of
+  `"Sturges"`, as `"Sturges"` tends to be too conservative (#214).
 * Several dependency reductions: removed {cowplot}, {purrr}, and {forcats}
   from *Suggests*; moved {tidyselect} and {dplyr} from *Imports* to *Suggests*.
   The latter two are only strictly necessary for `curve_interval()` due to its

diff --git a/R/density.R b/R/density.R
@@ -329,7 +329,7 @@ density_bounded = auto_partial(name = "density_bounded", function(
 #' @export
 density_histogram = auto_partial(name = "density_histogram", function(
   x, weights = NULL,
-  breaks = "Sturges",
+  breaks = "Scott",
   align = "none",
   outline_bars = FALSE,
   na.rm = FALSE,

diff --git a/R/stat_slabinterval.R b/R/stat_slabinterval.R
@@ -492,7 +492,7 @@ StatSlabinterval = ggproto("StatSlabinterval", AbstractStatSlabinterval,
     adjust = 1,
     trim = TRUE,
     expand = FALSE,
-    breaks = "Sturges",
+    breaks = "Scott",
     align = "none",
     outline_bars = FALSE,
 

diff --git a/R/weighted_hist.R b/R/weighted_hist.R
@@ -6,7 +6,7 @@
 
 #' @importFrom rlang as_label enexpr get_expr
 weighted_hist = function(
-  x, weights = NULL, breaks = "Sturges", align = "none"
+  x, weights = NULL, breaks = "Scott", align = "none"
 ) {
   x_label = as_label(enexpr(x))
   weights_label = as_label(enexpr(weights))

diff --git a/man/density_histogram.Rd b/man/density_histogram.Rd
diff --git a/man/stat_ccdfinterval.Rd b/man/stat_ccdfinterval.Rd
diff --git a/man/stat_cdfinterval.Rd b/man/stat_cdfinterval.Rd
diff --git a/man/stat_eye.Rd b/man/stat_eye.Rd
diff --git a/man/stat_gradientinterval.Rd b/man/stat_gradientinterval.Rd
diff --git a/man/stat_halfeye.Rd b/man/stat_halfeye.Rd
diff --git a/man/stat_histinterval.Rd b/man/stat_histinterval.Rd
diff --git a/man/stat_slab.Rd b/man/stat_slab.Rd
diff --git a/man/stat_slabinterval.Rd b/man/stat_slabinterval.Rd
diff --git a/man/stat_spike.Rd b/man/stat_spike.Rd
diff --git a/tests/testthat/_snaps/test.stat_sample_slabinterval/histinterval-with-outline.svg b/tests/testthat/_snaps/test.stat_sample_slabinterval/histinterval-with-outline.svg