Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update URLs #72

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Update URLs #72

merged 1 commit into from
Sep 18, 2023

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Sep 18, 2023

No description provided.

ofek
ofek approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Do you mind if we credit Datadog for the creation of this somewhere?

@oprypin
Copy link
Contributor Author

oprypin commented Sep 18, 2023

Yes actually we should! I forgot to suggest - something similar to mkdocs/mkdocs-redirects#32 (comment)

@oprypin oprypin merged commit 280137e into master Sep 18, 2023
14 checks passed
@oprypin oprypin deleted the name branch September 18, 2023 15:58
@ofek
Copy link
Collaborator

ofek commented Sep 18, 2023

Oh cool, I didn't realize there is precedence. I'll let you come up with the right wording though and I'll ✅ whatever you say

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oprypin @ofek