Change setSearch to handle SearchParams.t #176
Merged
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesnx
approved these changes
Oct 29, 2024
packages/url/native/URL.re
Outdated
| @@ -214,8 +214,12 @@ let search = url => { | |||
| | _ => Some("?" ++ Uri.encoded_of_query(~scheme, query)) | |||
| }; | |||
| }; | |||
| let setSearch = (t, string) => { | |||
| Uri.with_query(t, Uri.query_of_encoded(string)); | |||
| let setSearchString = (t, searchString) => { | |||
There was a problem hiding this comment.
I would rename this to setSearchAsString
davesnx
reviewed
Oct 29, 2024
packages/url/native/URL.re
Outdated
Comment on lines
221
to
222
| let queryString = SearchParams.toString(searchParams); | ||
| setSearchString(t, queryString); |
There was a problem hiding this comment.
no need to transform toString here, Uri.with_query should do the job, right?
pedrobslisboa
force-pushed
the
feat/improve_uri_setSearch
branch
from
7929444
to
c3303c8
Compare
pedrobslisboa
force-pushed
the
feat/improve_uri_setSearch
branch
from
c3303c8
to
6f23072
Compare
davesnx
added a commit
that referenced
this pull request
Oct 30, 2024
… into rsc * 'main' of github.com:ml-in-barcelona/server-reason-react: Handle DomProps with both jsx and html attribute name (#171) Change setSearch to handle SearchParams.t (#176) doc: add @@platform attribute documentation (#175) Support non-ascii on JS.String.toLowerCase and toUpperCase (#173) Fix snapshot test for external Upperbound reason to 3.10 feat: add nested mel.obj support (#169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the
setSearchto handle SearchParams.t and addsetSearchStringto handle stringsNew API