Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore cosmos_integration.py inside of the text_reading project #263

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

enoriega
Copy link
Member

Reverts the location of the script within the Scala sub directory such that it is part of Docker's context at build time.
Fixes #262

… that it is part of Docker's context at build time
@enoriega enoriega added this to the [DARPA] Milestone 9 milestone Jun 23, 2023
@enoriega
Copy link
Member Author

@myedibleenso This script is a utility function, just like the other shell scripts in the root level directory of text reading.
By restoring this, the annotat_cosmos_json shell script is functional again. Currently, the folks from UWisconsin are the primary users of this image

Copy link
Collaborator

@myedibleenso myedibleenso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enoriega , can you please also remove the associated scripts entry from pyproject.toml?

skema-tr-cosmos-integration = "skema.text_reading.cosmos_integration:main"

Removed the script entry for cosmos integration
Copy link
Collaborator

@myedibleenso myedibleenso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @enoriega !

@myedibleenso myedibleenso merged commit de98703 into main Jun 23, 2023
4 checks passed
@myedibleenso myedibleenso deleted the issue262 branch June 23, 2023 23:48
github-actions bot added a commit that referenced this pull request Jun 24, 2023
)

Reverts the location of the script within the Scala sub directory such
that it is part of Docker's context at build time.
Fixes #262

---------

Co-authored-by: Gus Hahn-Powell <[email protected]> de98703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cosmos_intergration.py script outside docker context directory
2 participants