CAST based MATLAB testing #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 16, 2023 22:44
Closed
Closed
jastier
pushed a commit
that referenced
this pull request
Oct 19, 2023
jastier
pushed a commit
that referenced
this pull request
Oct 19, 2023
titomeister
approved these changes
Oct 20, 2023
| cast = parser.out_cast | ||
| """ Tests parser assignment CAST """ | ||
|
|
||
| source = 'x = 5;' |
There was a problem hiding this comment.
I think hardcoding the source like this is okay to do for the tests right now, I do effectively this in my test scripts, but I want to note that at some point we will be changing tests to access test files that are online on a google drive. I think we just haven't decided how to go about doing that yet.
There was a problem hiding this comment.
Sure, that's how I had been doing it. I can easily switch back if needed.
github-actions bot
added a commit
that referenced
this pull request
Oct 20, 2023
## Testing of MATLAB idioms using CAST structures This PR is a refactor of the original test plan where MATLAB parser output was tested as a python dictionary. CAST testing uses fewer lines of code to achieve the same results and follows existing SKEMA test plans. ## Relevant Features - CAST elements are used to test MATLAB idioms - Source code is now defined within each test file - The test file data directory is no longer needed and has been removed - The MATLAB parser now takes file or string source code input ## Related Issues - Completes issue #570 --------- Co-authored-by: Joseph Astier <[email protected]> 52de34d
Merged
jastier
added a commit
that referenced
this pull request
Nov 1, 2023
## CAST test upgrades
This PR includes some test utilities for use when testing CAST output,
so common tests such as an assignment or an expression can be done as
single function calls. Some debug scripts are now executables. Minor
edits and code cleanup
## What's New
- Added `skema/program_analysis/CAST/matlab/tests/utils.py` with
functions for common testing tasks
- Added 3 conditional logic tests:
`if`
`if else`
`if elseif else`
## Relevant issues
Related to PR #613 and #583
---------
Co-authored-by: Joseph Astier <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Nov 1, 2023
## CAST test upgrades
This PR includes some test utilities for use when testing CAST output,
so common tests such as an assignment or an expression can be done as
single function calls. Some debug scripts are now executables. Minor
edits and code cleanup
## What's New
- Added `skema/program_analysis/CAST/matlab/tests/utils.py` with
functions for common testing tasks
- Added 3 conditional logic tests:
`if`
`if else`
`if elseif else`
## Relevant issues
Related to PR #613 and #583
---------
Co-authored-by: Joseph Astier <[email protected]> 77c96cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing of MATLAB idioms using CAST structures
This PR is a refactor of the original test plan where MATLAB parser output was tested as a python dictionary. CAST testing uses fewer lines of code to achieve the same results and follows existing SKEMA test plans.
Relevant Features
Related Issues