Fn-Preprocessing #602
Merged
Fn-Preprocessing #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentraymond-ua
approved these changes
Oct 31, 2023
github-actions bot
added a commit
that referenced
this pull request
Oct 31, 2023
This adds a util function to the REST API that takes in a function network and checks for all known bugs that can cause a deserialization error downstream. It then addresses the bugs in a generic fashion to allow serialization (although the FN is not correct, just digestible). It also outputs a log which contains every bug it has found and recording the type of bug and where the bug is inside the FN. I call this FN-Preprocessing on the FN's generated in the larger workflows as well. I also setup some error handling incase the dynamics could not be parsed in code2amr. Returning a blank/default AMR instead of a crash. --------- Co-authored-by: Justin <[email protected]> df3e789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a util function to the REST API that takes in a function network and checks for all known bugs that can cause a deserialization error downstream. It then addresses the bugs in a generic fashion to allow serialization (although the FN is not correct, just digestible). It also outputs a log which contains every bug it has found and recording the type of bug and where the bug is inside the FN.
I call this FN-Preprocessing on the FN's generated in the larger workflows as well.
I also setup some error handling incase the dynamics could not be parsed in code2amr. Returning a blank/default AMR instead of a crash.