[Python] Function Keyword Argument and Function Call through Parameter PR #644
Conversation
titomeister
changed the title
| @@ -129,3 +129,16 @@ class Range: | |||
|
|
|||
| def exec(input: int) -> range: | |||
| return range(input) | |||
|
|
|||
|
|
|||
| class Call: | |||
There was a problem hiding this comment.
We eventually will want to stop using the primitives in skema/gromet/execution_engine/types/ since they are artifacts left over from an outdated version of the execution engine. We have a YAML file which I believe should compile the same information in a more approachable way at skema/gromet/primitive_map.yaml
How large of a change would this require for the Gromet generation?
This is also something we may want to combine with python_builtins.yaml or create a home directory for these type of files.
There was a problem hiding this comment.
Oh okay. I had forgotten about that. I think as long as we can use the same interface all that would be needed would be to update what's going on behind the scenes. That is, I just need to change the interface to pull from the correct primitive map file. I don't expect there to be any reason to explicitly change anything in the Gromet generation code itself.
| foo(x=a,y=b,z=1) | ||
| """ | ||
|
|
||
| def generate_gromet(test_file_string): |
There was a problem hiding this comment.
This is a minor thing, but since this function is defined in multiple test files, it may be useful to add it to skema/utils
There was a problem hiding this comment.
Right, there's a lot of repetitive things in the test cases that I would eventually like to add there. This is another good thing to add though.
… into ferra/climlab_func_def_issue
myedibleenso
added
bug
github-actions
bot
removed
Code2FN
tests
|
@titomeister , can you please run |
I run into this error when I run that script. I'm not sure what the cause is at this time.
|
|
@titomeister - Could you reinstall Skema and see if that error goes away? I have a feeling that this is something that may have been added since you last installed the project. |
|
This is a bug in my code I believe. I am now putting up a PR that should fix it. |
Thank you @vincentraymond-ua, that resolved that problem! Working on some stuff with the report it generated now. |
There was a problem hiding this comment.
@titomeister - Looks good! Sorry for taking so long to re-review it.
No worries! Thank you for looking at it. |
…r PR (#644) ### GroMEt generation - Added support for handling the GroMEt primitive "_call" - Fixed an issue with the unpacking of a tuple from an attribute item - Fixed an issue with packing of a tuple in function calls. - Added some additional code to make the handling of Attributes more robust - Fixed an issue with functions being used as keyword arguments - Fixed an issue with port indices being too large in some wires. ### Python to CAST - Added a table to maintain a function's arguments. This is used to determine if an argument is being called as a function. - Added support for generating a primitive "_call" Function Call node that's used whenever a function that's passed as a function parameter is being called. ### Other - Added "_call" primitive to the execution engine's set of primitives in order to properly support GroMEt generation for it. ### Testing - Added a test file that checks that the generation and use of the "_call" primitive is correct and consistent. Resolves #592 --------- Co-authored-by: Vincent Raymond <[email protected]> Co-authored-by: Gus Hahn-Powell <[email protected]> bd15457
GroMEt generation
Python to CAST
Other
Testing
Resolves #592