Update ECR image name

ml6team · Jan 23, 2024 · 042d943 · 042d943
1 parent 73573c3
commit 042d943
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/images/Dockerfile b/images/Dockerfile
@@ -7,7 +7,6 @@ RUN apt-get update && \
     apt-get install git -y
 
 # Install Fondant
-# This is split from other requirements to leverage caching
 ARG FONDANT_VERSION=main
 RUN pip3 install fondant[component,aws,azure,gcp]@git+https://github.com/ml6team/fondant@${FONDANT_VERSION}
 
diff --git a/scripts/build_base_image.sh b/scripts/build_base_image.sh
@@ -39,8 +39,8 @@ for python_version in "${python_versions[@]}"; do
 
     # Build docker images and push to docker hub
     docker build --push "${args[@]}" \
-    --build-arg PYTHON_VERSION=$python_version \
-    --build-arg FONDANT_VERSION=$tag \
+    --build-arg="PYTHON_VERSION=${python_version}" \
+    --build-arg="FONDANT_VERSION=${tag}" \
     -f "images/Dockerfile" \
    .
 done