Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Related to #313 The local and remote runner store the manifest in different locations: * For the local runner, the manifest save path is set at compile time to a fixed path that we specify `{base_path}/{component_name}/manifest.json"` * For the remote runner (kfp), the `output_manifest_path` is set as an output artifact type. This is needed for chaining component together. The save path in this case is save internally within the VM `/tmp/outputs/output_manifest_path/data` and then mapped to minio storage after the component run (which then gets mapped to a cloud storage). The mapping saves the artifact to the specified base path followed by a fixed file structure that cannot be changed and also stored. It is also stored as zip file which contains the written text file (manifest) Example: ``` minio://soy-audio-379412_kfp-artifacts/artifacts/datacomp-filtering-pipeline-wvglp/2023/07/26/datacomp-filtering-pipeline-wvglp-3788902962/load-from-hub-output_manifest_path.tgz ``` where `/soy-audio-379412_kfp-artifacts` is the artifact bucket specified when deploying KFP. This PR unifies the manifest save path for both local and remote runner. It checks whether the `save_path` matches the expected kubeflow path and if so, save it both to the expected kfp artifact path (needed for chaining component) and the custom path that we require for caching. It's not the most optimal solution since we're writing the file twice but I don't see any other clear cut solution. @ChristiaensBert I think this might also fix some issues with the data explorer.
- Loading branch information