Centralize logging configuration #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NielsRogge
approved these changes
Jun 23, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
I was getting double logs with the local runner and was never a fan of the `configure_logging` utility function which had to be called by the user. This sets the logging format and level centrally in a way that doesn't overwrite already configured handlers and can easily be overwritten for each separate logger by the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting double logs with the local runner and was never a fan of the
configure_loggingutility function which had to be called by the user. This sets the logging format and level centrally in a way that doesn't overwrite already configured handlers and can easily be overwritten for each separate logger by the user.