Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more Ruff rules #231

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Enable more Ruff rules #231

merged 1 commit into from
Jun 23, 2023

Conversation

RobbeSneyders
Copy link
Member

My IDE was highlighting additional warnings not covered by Ruff, so I added some more rules. 90% of this was autofixed, the rest was straightforward and useful. I even found an issue with a test because of it.

) as o:
yield yaml.safe_load(c), json.load(o)


@pytest.mark.parametrize("component_spec, output_manifest", list(examples()))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed automatically. Is this not logical?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised it worked before the fix

@RobbeSneyders RobbeSneyders merged commit 309a886 into main Jun 23, 2023
@RobbeSneyders RobbeSneyders deleted the feature/more-ruff branch June 23, 2023 11:58
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
My IDE was highlighting additional warnings not covered by Ruff, so I
added some more rules. 90% of this was autofixed, the rest was
straightforward and useful. I even found an issue with a test because of
it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants