-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring logging functions / make the error messages more closely match gcc
s output
#249
Conversation
and shuffled error messages s.t. it more closely follows the output of gcc
615f107
to
6a51974
Compare
85f967e
to
d4dbf49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
I left a comment about extras/lambda-buffers-utils
to keep the compilation level separation. Let me know if that works
61a960b
to
0acd00c
Compare
0acd00c
to
e1a1ac9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank youuuu!!!
remove useless `cabal.project` entry
…`dev-lambda-buffers-(utils|frontend|codegen|compiler)`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I reviewed this earlier...
a76b0dc
to
4c89749
Compare
I'll merge this since it seems we've addressed all PR feedback :P |
This PR:
logError
andlogInfo
functions (fromlambda-buffers-frontend
andlambda-buffers-codegen
) to reuse the logging functions inlambda-buffers-compiler
sincelambda-buffers-compiler
is an existing dependency of bothlambda-buffers-frontend
andlambda-buffers-codegen
stderr
instead ofstdout
(this is more aligned with other compilers' behaviors)gcc
outputs e.g.