Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable retry mechanism - get-generic-sys-util #476

Merged
merged 9 commits into from
Nov 26, 2024

Conversation

anandhu-eng
Copy link
Contributor

In reference to issue: mlcommons/mlperf-automations#11

@anandhu-eng anandhu-eng requested a review from a team as a code owner November 4, 2024 10:28
Copy link

github-actions bot commented Nov 4, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@arjunsuresh
Copy link
Contributor

Thank you @anandhu-eng We should try to separate the retry logic from the main script logic either using a separate script or function for implementing the retry logic. We can discuss this. Also, we need to make sure the logic is working as expected.

@anandhu-eng
Copy link
Contributor Author

Sure @arjunsuresh . So lets close this PR ?

@arjunsuresh
Copy link
Contributor

@anandhu-eng No. Lets try to test it in a real scenario.

@arjunsuresh
Copy link
Contributor

Hi @anandhu-eng I think we can keep both install.sh and install-with-retry.sh and select the second if the ENV variable CM_SYS_UTIL_INSTALL_WITH_RETRY is set. Then we can merge this PR.

@anandhu-eng
Copy link
Contributor Author

Hi @anandhu-eng I think we can keep both install.sh and install-with-retry.sh and select the second if the ENV variable CM_SYS_UTIL_INSTALL_WITH_RETRY is set. Then we can merge this PR.

Hi @arjunsuresh , implemented the change in commit 65fc3a1

@arjunsuresh arjunsuresh merged commit 373d1fb into mlperf-inference Nov 26, 2024
104 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@arjunsuresh arjunsuresh deleted the anandhu-eng-patch-2 branch November 26, 2024 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants