Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase datasets description length #605

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/medperf/entities/benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class Benchmark(Entity, ApprovableSchema, DeployableSchema):
what models to run and how to evaluate them.
"""

description: Optional[str] = Field(None, max_length=20)
description: Optional[str] = Field(None, max_length=256)
docs_url: Optional[HttpUrl]
demo_dataset_tarball_url: str
demo_dataset_tarball_hash: Optional[str]
Expand Down
4 changes: 2 additions & 2 deletions cli/medperf/entities/dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ class Dataset(Entity, DeployableSchema):
data preparation output.
"""

description: Optional[str] = Field(None, max_length=20)
location: Optional[str] = Field(None, max_length=20)
description: Optional[str] = Field(None, max_length=256)
location: Optional[str] = Field(None, max_length=256)
input_data_hash: str
generated_uid: str
data_preparation_mlcube: Union[int, str]
Expand Down
23 changes: 23 additions & 0 deletions server/benchmark/migrations/0003_auto_20240819_2132.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Generated by Django 3.2.20 on 2024-08-19 21:32

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
('benchmark', '0002_alter_benchmark_demo_dataset_tarball_url'),
]

operations = [
migrations.AlterField(
model_name='benchmark',
name='description',
field=models.CharField(blank=True, max_length=256),
),
migrations.AlterField(
model_name='benchmark',
name='name',
field=models.CharField(max_length=64, unique=True),
),
]
4 changes: 2 additions & 2 deletions server/benchmark/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ class Benchmark(models.Model):
("OPERATION", "OPERATION"),
)

name = models.CharField(max_length=20, unique=True)
description = models.CharField(max_length=100, blank=True)
name = models.CharField(max_length=64, unique=True)
description = models.CharField(max_length=256, blank=True)
docs_url = models.CharField(max_length=100, blank=True)
owner = models.ForeignKey(User, on_delete=models.PROTECT)
demo_dataset_tarball_url = models.CharField(max_length=256)
Expand Down
18 changes: 18 additions & 0 deletions server/dataset/migrations/0005_alter_dataset_description.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Generated by Django 3.2.20 on 2024-07-22 16:50

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
('dataset', '0004_auto_20231211_1827'),
]

operations = [
migrations.AlterField(
model_name='dataset',
name='description',
field=models.CharField(blank=True, max_length=256),
),
]
23 changes: 23 additions & 0 deletions server/dataset/migrations/0006_auto_20240819_2132.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Generated by Django 3.2.20 on 2024-08-19 21:32

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
('dataset', '0005_alter_dataset_description'),
]

operations = [
migrations.AlterField(
model_name='dataset',
name='location',
field=models.CharField(blank=True, max_length=256),
),
migrations.AlterField(
model_name='dataset',
name='name',
field=models.CharField(max_length=64),
),
]
6 changes: 3 additions & 3 deletions server/dataset/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ class Dataset(models.Model):
("OPERATION", "OPERATION"),
)

name = models.CharField(max_length=20)
description = models.CharField(max_length=20, blank=True)
location = models.CharField(max_length=100, blank=True)
name = models.CharField(max_length=64)
description = models.CharField(max_length=256, blank=True)
location = models.CharField(max_length=256, blank=True)
owner = models.ForeignKey(User, on_delete=models.PROTECT)
input_data_hash = models.CharField(max_length=128)
generated_uid = models.CharField(max_length=128)
Expand Down
2 changes: 1 addition & 1 deletion server/mlcube/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class MlCube(models.Model):
("OPERATION", "OPERATION"),
)

name = models.CharField(max_length=20, unique=True)
name = models.CharField(max_length=64, unique=True)
git_mlcube_url = models.CharField(max_length=256)
mlcube_hash = models.CharField(max_length=100)
git_parameters_url = models.CharField(max_length=256, blank=True)
Expand Down
18 changes: 18 additions & 0 deletions server/result/migrations/0003_alter_modelresult_name.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Generated by Django 3.2.20 on 2024-08-19 21:32

from django.db import migrations, models


class Migration(migrations.Migration):

dependencies = [
('result', '0002_auto_20231124_0208'),
]

operations = [
migrations.AlterField(
model_name='modelresult',
name='name',
field=models.CharField(blank=True, max_length=64),
),
]
2 changes: 1 addition & 1 deletion server/result/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class ModelResult(models.Model):
("REJECTED", "REJECTED"),
)

name = models.CharField(max_length=20, blank=True)
name = models.CharField(max_length=64, blank=True)
owner = models.ForeignKey(User, on_delete=models.PROTECT)
benchmark = models.ForeignKey("benchmark.Benchmark", on_delete=models.CASCADE)
model = models.ForeignKey("mlcube.MlCube", on_delete=models.PROTECT)
Expand Down
Loading