Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use QR, add demo, add tests, add benchmark #12

Closed
wants to merge 4 commits into from
Closed

fix: use QR, add demo, add tests, add benchmark #12

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2023

Diff is due to a json file for benchmarking.

Ideas (for the future.)

  • The arguments to helper functions toLatex, toString may actually need to be optional. This will require an API change.
  • Unless data is standardised, calculations will blow up when higher degrees are used. The current demo shows this effect appears at n=7.

Comments

  • Benchmark comparison to previous code shows it is approximately the same execution time.

closes #10
closes #11

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1008275) 97.76% compared to head (9ca51fb) 97.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   97.76%   97.96%   +0.20%     
==========================================
  Files           1        1              
  Lines         179      197      +18     
  Branches       30       32       +2     
==========================================
+ Hits          175      193      +18     
  Misses          4        4              
Files Coverage Δ
src/index.ts 97.96% <100.00%> (+0.20%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost ghost marked this pull request as ready for review October 23, 2023 15:54
@ghost ghost marked this pull request as draft October 24, 2023 08:36
@ghost ghost closed this by deleting the head repository May 16, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"LU matrix is singular" Error for well-behaving data (LuDecomposition.solve in ml-matrix) Add demo
0 participants