Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BERT #30

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

BERT #30

wants to merge 11 commits into from

Conversation

mrityunjay-tripathi
Copy link
Member

No description provided.

Copy link

@lozhnikov lozhnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

models/bert/bert_tokenizer.hpp Outdated Show resolved Hide resolved
utils/utils.hpp Outdated Show resolved Hide resolved
utils/utils.hpp Outdated Show resolved Hide resolved
utils/utils.hpp Outdated Show resolved Hide resolved
utils/utils.hpp Outdated Show resolved Hide resolved
@mlpack-bot
Copy link

mlpack-bot bot commented Oct 30, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@ayushsingh11
Copy link

ayushsingh11 commented Mar 7, 2021

My bad, I didn't know that there was an attempt to add BERT Tokenizer earlier as well.
Hence, I have added a PR - mlpack/mlpack#2822 .
But, it is for the 'mlpack' repos, not 'models'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants